From: David Woodhouse <dwmw2@infradead.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: maps: Blackfin async: rename local funcs to avoid common clashes
Date: Thu, 25 Feb 2010 11:32:07 +0000 [thread overview]
Message-ID: <1267097527.30247.6163.camel@macbook.infradead.org> (raw)
In-Reply-To: <1263743566-26986-1-git-send-email-vapier@gentoo.org>
On Sun, 2010-01-17 at 10:52 -0500, Mike Frysinger wrote:
> state->map.name = DRIVER_NAME;
> - state->map.read = bfin_read;
> - state->map.copy_from = bfin_copy_from;
> - state->map.write = bfin_write;
> - state->map.copy_to = bfin_copy_to;
> +#ifdef CONFIG_MTD_COMPLEX_MAPPINGS
> + state->map.read = bfin_flash_read;
> + state->map.copy_from = bfin_flash_copy_from;
> + state->map.write = bfin_flash_write;
> + state->map.copy_to = bfin_flash_copy_to;
> +#endif
Why add the #ifdef? This driver depends on MTD_COMPLEX_MAPPINGS in
Kconfig, and rightly so -- it can never work as a 'simple' mapping.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2010-02-25 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 15:52 [PATCH] mtd: maps: Blackfin async: rename local funcs to avoid common clashes Mike Frysinger
2010-02-02 6:01 ` Artem Bityutskiy
2010-02-25 11:32 ` David Woodhouse [this message]
2010-02-25 11:50 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267097527.30247.6163.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox