From: David Woodhouse <dwmw2@infradead.org>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MTD: Suppress warnings in inline_map_read()
Date: Sat, 10 Apr 2010 10:26:22 +0100 [thread overview]
Message-ID: <1270891582.4704.102.camel@macbook.infradead.org> (raw)
In-Reply-To: <fb80b9139bec21ac8bd4ddcec0abeb9c1ad39ad5@localhost.localdomain>
On Fri, 2010-04-09 at 15:45 -0700, Kevin Cernekee wrote:
> With gcc 4.4.3 -O2 on MIPS32:
>
> drivers/mtd/chips/cfi_util.c: In function 'cfi_qry_present':
> include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function
> include/linux/mtd/map.h:375: note: 'r' was declared here
> include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function
> include/linux/mtd/map.h:375: note: 'r' was declared here
>
> Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
I suspect 'else BUG()' would be a better fix.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2010-04-10 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 22:45 [PATCH] MTD: Suppress warnings in inline_map_read() Kevin Cernekee
2010-04-10 9:26 ` David Woodhouse [this message]
2010-04-10 18:18 ` [PATCHv2] " Kevin Cernekee
2010-04-27 7:46 ` Artem Bityutskiy
2010-05-04 13:04 ` Artem Bityutskiy
2010-05-04 20:06 ` Kevin Cernekee
2010-05-05 12:11 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270891582.4704.102.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=cernekee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).