From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brijesh Singh <brij.singh@samsung.com>
Cc: Artem.Bityutskiy@nokia.com, rohit.dongre@samsung.com,
brijesh.s.singh@gmail.com, linux-mtd@lists.infradead.org,
rohitvdongre@gmail.com, David Woodhouse <dwmw2@infradead.org>
Subject: Re: PATCH 1/7] ubi: logging feature for ubi
Date: Wed, 21 Apr 2010 05:44:41 +0300 [thread overview]
Message-ID: <1271817881.11751.1366.camel@localhost.localdomain> (raw)
In-Reply-To: <q2p6b5362aa1004120135l28e57df1kc51c284620ca0033@mail.gmail.com>
On Mon, 2010-04-12 at 14:05 +0530, Brijesh Singh wrote:
> Hi,
> I am sending the patches that add logging support to UBI.
>
Very quick comments.
1. I think UBIL should not be under #ifdef's, why do we need so many
ifdefs around?
2. This is a lot of code, and a short doc what you do is really needed.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-04-21 2:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 8:35 PATCH 1/7] ubi: logging feature for ubi Brijesh Singh
2010-04-21 2:44 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271817881.11751.1366.camel@localhost.localdomain \
--to=dedekind1@gmail.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=brij.singh@samsung.com \
--cc=brijesh.s.singh@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rohit.dongre@samsung.com \
--cc=rohitvdongre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox