From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH v2] MTD: Fix Orion NAND driver compilation with ARM OABI From: Artem Bityutskiy To: Paulius Zaleckas In-Reply-To: <4BB33988.9070608@gmail.com> References: <20100325152505.17612.40158.stgit@pauliusz> <4BB33988.9070608@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 23 Apr 2010 14:56:18 +0300 Message-ID: <1272023778.6917.6.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Nicolas Pitre , jamie@shareable.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, u.kleine-koenig@pengutronix.de, simon.kagstrom@netinsight.net, akpm@linux-foundation.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2010-03-31 at 15:01 +0300, Paulius Zaleckas wrote: > On 03/25/2010 06:26 PM, Nicolas Pitre wrote: > > On Thu, 25 Mar 2010, Paulius Zaleckas wrote: > > > >> We must tell GCC to use even register for variable passed > >> to ldrd instruction. Without this patch GCC 4.2.1 puts this > >> variable to r2/r3 on EABI and r3/r4 on OABI, so force it to > >> r2/r3. This does not change anything when EABI and OABI > >> compilation works OK. > >> > >> Without this patch and with OABI I get: > >> CC drivers/mtd/nand/orion_nand.o > >> /tmp/ccMkwOCs.s: Assembler messages: > >> /tmp/ccMkwOCs.s:63: Error: first destination register must be even -- `ldrd r3,[ip]' > >> make[5]: *** [drivers/mtd/nand/orion_nand.o] Error 1 > >> > >> Signed-off-by: Paulius Zaleckas > > > > Acked-by: Nicolas Pitre > > David, > > Will you take this patch? > Or you are waiting till I will add all Cc as Jamie suggested? Meanwhile, I've pushed your patch to my l2-mtd-2.6.git / dunno. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)