From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: MTD mailing list <linux-mtd@lists.infradead.org>
Subject: Re: simplifying the linux MTD Kconfig/Makefile structure
Date: Fri, 23 Apr 2010 15:05:46 +0300 [thread overview]
Message-ID: <1272024346.6917.10.camel@localhost> (raw)
In-Reply-To: <alpine.LFD.2.00.1003300824320.6061@localhost>
On Tue, 2010-03-30 at 08:29 -0400, Robert P. J. Day wrote:
> it seems like the various Kconfigs and Makefiles related to MTD
> could be tightened up a bit. for instance, in drivers/mtd/Makefile:
>
> obj-$(CONFIG_MTD_UBI) += ubi/
>
> but given that selection, it's kind of redundant to then have
> drivers/mtd/ubi/Makefile start with:
>
> obj-$(CONFIG_MTD_UBI) += ubi.o
>
> is it not? why not just "obj-y"?
>
> along those lines, again from drivers/mtd/Makefile:
>
> obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/ tests/
>
> obj-$(CONFIG_MTD_UBI) += ubi/
>
> why not be consistent and have:
>
> obj-y += chips/ lpddr/ maps/ devices/ nand/ onenand/
>
> obj-$(CONFIG_MTD_UBI) += ubi/
> obj-$(CONFIG_MTD_TESTS) += tests/
>
> which would *massively* simplify drivers/mtd/tests/Makefile, would it
> not?
>
> i can submit some patches if there's any interest. i suspect some
> of the other directories could be similarly tidied up.
Sounds like a reasonable clean-up to me.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-04-23 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 12:29 simplifying the linux MTD Kconfig/Makefile structure Robert P. J. Day
2010-04-23 12:05 ` Artem Bityutskiy [this message]
2010-05-13 18:27 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272024346.6917.10.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox