Re: [PATCH] jffs2: Move erasing from write_super to GC.

Joakim Tjernlund
2010-05-19T20:08:27Z

David Woodhouse <dwmw2@infradead.org> wrote on 2010/05/19 18:49:08:
>
> On Wed, 2010-05-19 at 11:47 +0200, Joakim Tjernlund wrote:
> >
> > > It could perhaps be broken into smaller simple patches along the lines
> > > of:
> > > - Add 'work_done' return value from jffs2_erase_pending_blocks()
> > > - Call jffs2_erase_pending_blocks() from jffs2_g_c_pass()
> > > - Fix the conditions under which jffs2_g_c_pass() will return -EINVAL,
> > > fix the way that jffs2_reserve_space() will respond to that, and fix
> > > jffs2_erase_succeeded() to actually wake up the erase_wait queue.
> > > - Remove locking from jffs2_garbage_collect_trigger() and require that
> > > callers have c->erase_completion_lock already held.
> > > - Change most callers of jffs2_erase_pending_trigger() to call
> > > jffs2_garbage_collect_trigger() instead. To comply with the locking
> > > rules, this may involve moving the call up or down a few lines, or
> > > sometimes adding a new lock/unlock pair around it.
> > > - Remove jffs2_erase_pending_blocks() call from jffs2_write_super().
> > > - Rename jffs2_erase_pending_trigger() and its only remaining caller
> > > in wbuf.c to jffs2_dirty_trigger().
> >
> > I have tried this on my 2.6.33 tree and it seems to work OK.
> > I am currenltly copying lots of files and deleting them in a loop,
> > so far so good :) Needed to "tweak":
>
> OK, this is now pushed, in some semblance of the above form. I think I
> got the attribution right on the bits which you wrote. Thanks again.

Thanks, I am sure you get attribution right, but where did you push?
Can't find it in http://git.infradead.org/mtd-2.6.git