From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brijesh Singh <brijesh.s.singh@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] UBI: fix delete compatible internal volume scan
Date: Sun, 23 May 2010 09:16:57 +0300 [thread overview]
Message-ID: <1274595417.8881.36.camel@localhost.localdomain> (raw)
In-Reply-To: <AANLkTimuYmRDCZCkoB9YHifngCwjp9_B2ucFQ1seaiM9@mail.gmail.com>
On Tue, 2010-05-18 at 23:10 +0530, Brijesh Singh wrote:
> This patch resolves a possible bug. Scan is adding delete compatible
> blocks to both corr list and used list.
> It should return after adding the block to corr list.
>
> Signed-off-by: Brijesh Singh <brijesh.s.singh@gmail.com>
I'm not sure this patch is enough. I think we should add a 'compat' flag
to the 'struct ubi_mkvol_req' structure, to make it possible to create
volumes with different compatibility flags. Then we need to write a test
and add it to the UBI test-suite at 'mtd-utils/tests/ubi-tests/'.
Then once we have tested and fixed this, we should merge this and also
send to the '-stable' trees.
I remember I did give the compat option a test, but probably not that
good.
I'll try to do what I've described as soon as I have time, but you guys
could do this as well, if you have bandwidth.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-05-23 6:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 17:40 [PATCH] UBI: fix delete compatible internal volume scan Brijesh Singh
2010-05-23 6:16 ` Artem Bityutskiy [this message]
2010-06-12 14:17 ` Artem Bityutskiy
2010-06-13 10:08 ` Artem Bityutskiy
2010-06-16 6:22 ` Artem Bityutskiy
2010-06-16 8:52 ` Brijesh Singh
2010-06-16 9:30 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274595417.8881.36.camel@localhost.localdomain \
--to=dedekind1@gmail.com \
--cc=brijesh.s.singh@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox