* [patch] mtd: return success on blktrans_ioctl()
@ 2010-05-31 14:03 Dan Carpenter
2010-06-13 9:08 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-05-31 14:03 UTC (permalink / raw)
To: David Woodhouse
Cc: Artem Bityutskiy, Maxim Levitsky, kernel-janitors,
H Hartley Sweeten, linux-mtd, Ben Hutchings
There was a break missing so we returned -ENOTTY on success instead of
zero. This was introduced by 048d8719956: "mtd: blktrans: Hotplug fixes"
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 03e19c1..a6bb586 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -245,6 +245,7 @@ static int blktrans_ioctl(struct block_device *bdev, fmode_t mode,
switch (cmd) {
case BLKFLSBUF:
ret = dev->tr->flush ? dev->tr->flush(dev) : 0;
+ break;
default:
ret = -ENOTTY;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] mtd: return success on blktrans_ioctl()
2010-05-31 14:03 [patch] mtd: return success on blktrans_ioctl() Dan Carpenter
@ 2010-06-13 9:08 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2010-06-13 9:08 UTC (permalink / raw)
To: Dan Carpenter
Cc: Maxim Levitsky, kernel-janitors, H Hartley Sweeten, linux-mtd,
Ben Hutchings, David Woodhouse
On Mon, 2010-05-31 at 16:03 +0200, Dan Carpenter wrote:
> There was a break missing so we returned -ENOTTY on success instead of
> zero. This was introduced by 048d8719956: "mtd: blktrans: Hotplug fixes"
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Pushed to l2-mtd-2.6.git, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-13 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-31 14:03 [patch] mtd: return success on blktrans_ioctl() Dan Carpenter
2010-06-13 9:08 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).