From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] mtd: OneNAND: Add runtime badblock check feature
Date: Sun, 13 Jun 2010 12:26:40 +0300 [thread overview]
Message-ID: <1276421200.19028.192.camel@localhost> (raw)
In-Reply-To: <1275380256-15315-1-git-send-email-jy0922.shim@samsung.com>
On Tue, 2010-06-01 at 17:17 +0900, Joonyoung Shim wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> This patch is to support runtime badblock checking. This supports only
> OneNAND currently. The OneNAND badblock checking when boots occurs boot
> time delay. We can reduce boot time because can detect badblock at
> runtime.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Hi, this feature is interesting. But why not to use bad block table
instead of adding more complexity to the already very complex and
difficult to follow code?
Also, if you really want this, it should be rather lazy checking, where
you read OOB on demand, and then save this information to the in-ram
BBT, and when you get another ->block_isbad() for a block which was
previously checked, you do not read OOB for the second time.
CCing Thomas, if we are lucky, he'll provide good input.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-06-13 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 8:17 [PATCH 1/2] mtd: OneNAND: Add runtime badblock check feature Joonyoung Shim
2010-06-01 8:17 ` [PATCH 2/2] mtd: OneNAND: Support runtime badblock check of Samsung Soc OneNAND Joonyoung Shim
2010-06-13 9:26 ` Artem Bityutskiy [this message]
2010-06-13 23:19 ` [PATCH 1/2] mtd: OneNAND: Add runtime badblock check feature Kyungmin Park
2010-06-14 4:07 ` Artem Bityutskiy
2010-06-29 6:38 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276421200.19028.192.camel@localhost \
--to=dedekind1@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).