From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.nokia.com ([192.100.122.233] helo=mgw-mx06.nokia.com) by bombadil.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1ONkBk-0004NQ-9k for linux-mtd@lists.infradead.org; Sun, 13 Jun 2010 10:13:13 +0000 Subject: Re: [PATCH] UBI: fix delete compatible internal volume scan From: Artem Bityutskiy To: Brijesh Singh In-Reply-To: <1276352277.19028.119.camel@localhost> References: <1274595417.8881.36.camel@localhost.localdomain> <1276352277.19028.119.camel@localhost> Content-Type: text/plain; charset="UTF-8" Date: Sun, 13 Jun 2010 13:08:53 +0300 Message-ID: <1276423733.19028.215.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-mtd@lists.infradead.org Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 2010-06-12 at 17:17 +0300, Artem Bityutskiy wrote: > On Sun, 2010-05-23 at 09:16 +0300, Artem Bityutskiy wrote: > > On Tue, 2010-05-18 at 23:10 +0530, Brijesh Singh wrote: > > > This patch resolves a possible bug. Scan is adding delete compatible > > > blocks to both corr list and used list. > > > It should return after adding the block to corr list. > > > > > > Signed-off-by: Brijesh Singh > > > > I'm not sure this patch is enough. I think we should add a 'compat' flag > > to the 'struct ubi_mkvol_req' structure, to make it possible to create > > volumes with different compatibility flags. Then we need to write a test > > and add it to the UBI test-suite at 'mtd-utils/tests/ubi-tests/'. > > > > Then once we have tested and fixed this, we should merge this and also > > send to the '-stable' trees. > > > > I remember I did give the compat option a test, but probably not that > > good. > > > > I'll try to do what I've described as soon as I have time, but you guys > > could do this as well, if you have bandwidth. > > I did not have time to do this so far, but still planning to do. Did you > go any further with your ubil? Actually, what I'm thinking to do is to create a test that creates various UBI images with different types of volume compatibility flags, and then tries to attach them. We have libubigen in mtd-utils, and with this library it should be is quite easy to create different images. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)