From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.nokia.com ([192.100.105.134] helo=mgw-mx09.nokia.com) by bombadil.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1OTUSl-0004xY-LF for linux-mtd@lists.infradead.org; Tue, 29 Jun 2010 06:38:32 +0000 Subject: Re: [PATCH v5 2/3] mtd-utils: support >4GiB devices From: Artem Bityutskiy To: Kevin Cernekee In-Reply-To: <1276342579.19028.116.camel@localhost> References: <5e05b5a05a30b2dc2035b87a60bb82f3137174cb@localhost.localdomain> <1273745471.22706.163.camel@localhost> <1276342579.19028.116.camel@localhost> Content-Type: text/plain; charset="UTF-8" Date: Tue, 29 Jun 2010 09:35:12 +0300 Message-ID: <1277793312.1041.963.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-mtd@lists.infradead.org, jwboyer@gmail.com, saeed.bishara@gmail.com Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 2010-06-12 at 14:36 +0300, Artem Bityutskiy wrote: > On Thu, 2010-05-13 at 13:11 +0300, Artem Bityutskiy wrote: > > > nandwrite.c | 60 +++++----- > > > 13 files changed, 570 insertions(+), 171 deletions(-) > > > create mode 100644 mtd_ioctl.c > > > create mode 100644 mtd_ioctl.h > > > > Any chance to extend and use mtd-utils/ubi-utils/src/libmtd.c instead of > > mtd_ioctl.c? > > Does silence mean that that answer is "no"? :-) I have a dilemma whether to take your patches as they are or not :-) On the one hand, they are needed, on the other hand, if we re-use libmtd.c, we do not have duplicated code. libmtd.c is tested and it distinguish beween old kernels (no sysfs support in mtd) and new kernels (expose stuff via sysfs). It would be nice to share more code... I guess I do not take your patches so far. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)