From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mark Ware <mware@elphinstone.net>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-mtd@lists.infradead.org
Subject: Re: [RFC/PATCH] doc2000: Fix uninitialized variable in doc_ecc_decode()
Date: Tue, 29 Jun 2010 09:50:40 +0300 [thread overview]
Message-ID: <1277794240.1041.973.camel@localhost> (raw)
In-Reply-To: <4C2996E7.9040209@elphinstone.net>
On Tue, 2010-06-29 at 16:47 +1000, Mark Ware wrote:
> On 29/06/10 16:29, Artem Bityutskiy wrote:
> > On Thu, 2010-05-27 at 11:45 +1000, Mark Ware wrote:
> >> The variable 'syn' was being used uninitialized. Also
> >> fixed incorrect use of syn[] vs s[].
> >>
> >> Tested on powerpc board with 64MB DOC2000.
> >> ---
> >>
> >> I am porting from a 2.4.18 kernel to 2.6.32, and I saw random media header
> >> mismatches causing a failure to detect the DOC device partitions. Tracing
> >> through, I saw this variable being used uninitialized and I suspect
> >> incorrectly also.
> >>
> >> I do not really understand how the ecc/syndrome code works, so I do not
> >> know if this patch is the correct solution, but it did make my problem
> >> go away...
> >>
> >> CC: Thomas Gleixner as I believe he may have written this function initially.
> >
> > Please, always add Signed-off-by for kernel patches. I added it for you.
> >
>
> Thanks. I guess I expected to be told that I was smoking something and that
> my DOC error disappearing was unrelated...
Note, I did not really review your patch - the MTD maintainer will take
a look at it later, probably.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-06-29 6:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 1:45 [RFC/PATCH] doc2000: Fix uninitialized variable in doc_ecc_decode() Mark Ware
2010-06-17 4:44 ` Mark Ware
2010-06-29 3:46 ` Artem Bityutskiy
2010-06-29 3:58 ` Artem Bityutskiy
2010-06-29 6:29 ` Artem Bityutskiy
2010-06-29 6:47 ` Mark Ware
2010-06-29 6:50 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277794240.1041.973.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mware@elphinstone.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).