From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <norris@broadcom.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd-utils: formatting of odd-sized OOB in nanddump
Date: Wed, 07 Jul 2010 17:07:54 +0300 [thread overview]
Message-ID: <1278511674.12733.18.camel@localhost> (raw)
In-Reply-To: <1276706527-4563-1-git-send-email-norris@broadcom.com>
On Wed, 2010-06-16 at 09:42 -0700, Brian Norris wrote:
> + if (i+15 < meminfo.oobsize) {
> + /* Print 16 bytes */
> + sprintf(pretty_buf, " OOB Data: %02x %02x %02x %02x %02x %02x "
> + "%02x %02x %02x %02x %02x %02x %02x %02x %02x %02x\n",
> + oobbuf[i], oobbuf[i+1], oobbuf[i+2],
> + oobbuf[i+3], oobbuf[i+4], oobbuf[i+5],
> + oobbuf[i+6], oobbuf[i+7], oobbuf[i+8],
> + oobbuf[i+9], oobbuf[i+10], oobbuf[i+11],
> + oobbuf[i+12], oobbuf[i+13], oobbuf[i+14],
> + oobbuf[i+15]);
> + write(ofd, pretty_buf, 60);
> + } else {
> + /* Print 10 bytes */
> + sprintf(pretty_buf, " OOB Data: %02x %02x %02x %02x %02x %02x "
> + "%02x %02x %02x %02x\n",
> + oobbuf[i], oobbuf[i+1], oobbuf[i+2],
> + oobbuf[i+3], oobbuf[i+4], oobbuf[i+5],
> + oobbuf[i+6], oobbuf[i+7], oobbuf[i+8],
> + oobbuf[i+9]);
> + write(ofd, pretty_buf, 42);
> + }
Why 10 bytes, why not 12 or 14?
I think it is better to just copy-paste-modify the kernel
print_hex_dump() and utilize it, instead of this ugly crocodile code ...
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-07-07 14:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 16:42 [PATCH] mtd-utils: formatting of odd-sized OOB in nanddump Brian Norris
2010-07-07 14:07 ` Artem Bityutskiy [this message]
2010-07-07 18:21 ` Brian Norris
2010-07-08 4:09 ` Artem Bityutskiy
2010-07-08 20:50 ` [PATCH] mtd-utils update Brian Norris
2010-07-08 20:50 ` [PATCH 1/6] mtd-utils/nanddump.c: Increase max OOB size Brian Norris
2010-07-18 7:17 ` Artem Bityutskiy
2010-07-08 20:50 ` [PATCH 2/6] mtd-utils/nanddump.c: Robust pretty hexdump Brian Norris
2010-07-18 7:18 ` Artem Bityutskiy
2010-07-08 20:50 ` [PATCH 3/6] mtd-utils/nanddump.c: Add canonical (hex+ascii) flag Brian Norris
2010-07-08 20:50 ` [PATCH 4/6] mtd-utils/mkfs.jffs2: fixed warnings Brian Norris
2010-07-18 7:19 ` Artem Bityutskiy
2010-07-08 20:50 ` [PATCH 5/6] mtd-utils/nandtest.c: Fixed indentation Brian Norris
2010-07-18 7:20 ` Artem Bityutskiy
2010-07-08 20:50 ` [PATCH 6/6] mtd-utils/nanddump.c: Add "forcebinary" flag Brian Norris
2010-07-08 22:03 ` Brian Norris
2010-07-18 7:23 ` Artem Bityutskiy
2010-07-19 17:33 ` [PATCH v2 2/6] mtd-utils/nanddump.c: Robust pretty hexdump Brian Norris
2010-07-21 9:54 ` Artem Bityutskiy
2010-07-19 17:33 ` [PATCH v2 3/6] mtd-utils/nanddump.c: Add canonical (hex+ascii) flag Brian Norris
2010-07-19 17:33 ` [PATCH v2 6/6] mtd-utils/nanddump.c: Add "forcebinary" flag Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278511674.12733.18.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=norris@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).