From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: return -1 if verify failed
Date: Tue, 13 Jul 2010 13:24:58 +0300 [thread overview]
Message-ID: <1279016698.31639.25.camel@localhost> (raw)
In-Reply-To: <4C2D12C1.3000801@gmail.com>
On Fri, 2010-07-02 at 00:12 +0200, Roel Kluin wrote:
> It should return -1 if the verify failed.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> I think this needed, correct?
>
> diff --git a/drivers/mtd/tests/mtd_pagetest.c b/drivers/mtd/tests/mtd_pagetest.c
> index 6bc1b82..7414888 100644
> --- a/drivers/mtd/tests/mtd_pagetest.c
> +++ b/drivers/mtd/tests/mtd_pagetest.c
> @@ -358,7 +358,7 @@ static int erasecrosstest(void)
> printk(PRINT_PREF "verify failed!\n");
> errcnt += 1;
> ok = 0;
> - return err;
> + return -1;
> }
Yeah, I changed your patch a bit and removed the 'ok' variable
altogether. Pushed to l2-mtd-2.6.git, please, check:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/4e2ef8529d9bc2e2b96f18a1a2917bda5475f0e4
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-07-13 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 22:12 [PATCH] mtd: return -1 if verify failed Roel Kluin
2010-07-13 10:24 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279016698.31639.25.camel@localhost \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).