* [PATCH] mtd: return -1 if verify failed
@ 2010-07-01 22:12 Roel Kluin
2010-07-13 10:24 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-07-01 22:12 UTC (permalink / raw)
To: David Woodhouse, linux-mtd, Andrew Morton, LKML
It should return -1 if the verify failed.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
I think this needed, correct?
diff --git a/drivers/mtd/tests/mtd_pagetest.c b/drivers/mtd/tests/mtd_pagetest.c
index 6bc1b82..7414888 100644
--- a/drivers/mtd/tests/mtd_pagetest.c
+++ b/drivers/mtd/tests/mtd_pagetest.c
@@ -358,7 +358,7 @@ static int erasecrosstest(void)
printk(PRINT_PREF "verify failed!\n");
errcnt += 1;
ok = 0;
- return err;
+ return -1;
}
printk(PRINT_PREF "erasing block %d\n", ebnum);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: return -1 if verify failed
2010-07-01 22:12 [PATCH] mtd: return -1 if verify failed Roel Kluin
@ 2010-07-13 10:24 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2010-07-13 10:24 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-mtd, Andrew Morton, David Woodhouse, LKML
On Fri, 2010-07-02 at 00:12 +0200, Roel Kluin wrote:
> It should return -1 if the verify failed.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> I think this needed, correct?
>
> diff --git a/drivers/mtd/tests/mtd_pagetest.c b/drivers/mtd/tests/mtd_pagetest.c
> index 6bc1b82..7414888 100644
> --- a/drivers/mtd/tests/mtd_pagetest.c
> +++ b/drivers/mtd/tests/mtd_pagetest.c
> @@ -358,7 +358,7 @@ static int erasecrosstest(void)
> printk(PRINT_PREF "verify failed!\n");
> errcnt += 1;
> ok = 0;
> - return err;
> + return -1;
> }
Yeah, I changed your patch a bit and removed the 'ok' variable
altogether. Pushed to l2-mtd-2.6.git, please, check:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/4e2ef8529d9bc2e2b96f18a1a2917bda5475f0e4
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-13 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-01 22:12 [PATCH] mtd: return -1 if verify failed Roel Kluin
2010-07-13 10:24 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).