From: Artem Bityutskiy <dedekind1@gmail.com>
To: Kyle Spaans <kspaans@uwaterloo.ca>
Cc: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] drivers/mtd: remove makefile subdirectory processing redundancies
Date: Sun, 18 Jul 2010 19:46:30 +0300 [thread overview]
Message-ID: <1279471590.16247.57.camel@localhost.localdomain> (raw)
In-Reply-To: <20100714042509.GA7775@caffeine.csclub.uwaterloo.ca>
On Wed, 2010-07-14 at 00:25 -0400, Kyle Spaans wrote:
> Remove redundant config checks when the subdirectory's Makefile is already
> conditionally processed. Add more conditional processing when the subdirectory
> can be selected/deselected as a whole.
>
> Signed-off-by: Kyle Spaans <kspaans@uwaterloo.ca>
> Reviewed-by: Robert P. J. Day <rpjday@crashcourse.ca>
> ---
This does not apply to the mtd-2.6.git tree [1]. Also I spotted that
...
> +obj-$(CONFIG_MTD_TESTS) += tests/
> +obj-$(CONFIG_MTD_LPDDR) += lpddr/
> +obj-$(CONFIG_MTD_NAND) += nand/
> +obj-$(CONFIG_MTD_ONENAND) += onenand/
> obj-$(CONFIG_MTD_BI) += ubi/
This cannot be right, because we have UBI, not 'BI'.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-07-18 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 4:25 [PATCH] drivers/mtd: remove makefile subdirectory processing redundancies Kyle Spaans
2010-07-18 16:46 ` Artem Bityutskiy [this message]
2010-07-20 2:17 ` Kyle Spaans
2010-07-21 10:09 ` Artem Bityutskiy
2010-08-04 0:58 ` Kyle Spaans
2010-08-24 8:17 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279471590.16247.57.camel@localhost.localdomain \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kspaans@uwaterloo.ca \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).