* [patch 2/4] drivers/mtd/tests/mtd_pagetest.c: return -1 if verify failed
@ 2010-07-20 22:24 akpm
2010-07-21 10:35 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2010-07-20 22:24 UTC (permalink / raw)
To: dwmw2; +Cc: roel.kluin, akpm, linux-mtd, cbou
From: Roel Kluin <roel.kluin@gmail.com>
It should return -1 if the verify failed.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Anton Vorontsov <cbou@mail.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/mtd/tests/mtd_pagetest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/mtd/tests/mtd_pagetest.c~mtd-return-1-if-verify-failed drivers/mtd/tests/mtd_pagetest.c
--- a/drivers/mtd/tests/mtd_pagetest.c~mtd-return-1-if-verify-failed
+++ a/drivers/mtd/tests/mtd_pagetest.c
@@ -358,7 +358,7 @@ static int erasecrosstest(void)
printk(PRINT_PREF "verify failed!\n");
errcnt += 1;
ok = 0;
- return err;
+ return -1;
}
printk(PRINT_PREF "erasing block %d\n", ebnum);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2/4] drivers/mtd/tests/mtd_pagetest.c: return -1 if verify failed
2010-07-20 22:24 [patch 2/4] drivers/mtd/tests/mtd_pagetest.c: return -1 if verify failed akpm
@ 2010-07-21 10:35 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2010-07-21 10:35 UTC (permalink / raw)
To: akpm; +Cc: roel.kluin, dwmw2, linux-mtd, cbou
On Tue, 2010-07-20 at 15:24 -0700, akpm@linux-foundation.org wrote:
> From: Roel Kluin <roel.kluin@gmail.com>
>
> It should return -1 if the verify failed.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Anton Vorontsov <cbou@mail.ru>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This patch, but in an improved form, is also in my l2-mtd-2.6.git /
master tree.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-21 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-20 22:24 [patch 2/4] drivers/mtd/tests/mtd_pagetest.c: return -1 if verify failed akpm
2010-07-21 10:35 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).