From: Ben Hutchings <bhutchings@solarflare.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 2.6.35] mtd: blktrans: Move device and module ref-counting back to open/release
Date: Sat, 24 Jul 2010 18:03:28 +0100 [thread overview]
Message-ID: <1279991008.4915.7.camel@localhost> (raw)
In-Reply-To: <AANLkTi=Aw=yFCsz4PArNoMVOpOU567ffzUHooVvXKQtF@mail.gmail.com>
On Sat, 2010-07-24 at 19:07 +0300, Maxim Levitsky wrote:
> This is done on purpose.
>
> Otherwise, as soon as someone registers mtd translation layer with partitions,
> the add_gendisk will scan partitions and thus call blktrans_open()
> and mtd_table_mutex is already held.
OK, I get it. Maybe that should be deferred to a work item.
> Here I can unload both mtd and blktrans driver after mtd driver
> removes mtd device (that happens when I remove the xD card)
> While card is inserted its indeed not possible to remove nether mtd
> nor translation layer driver.
This only works if the MTD itself is hotplugged, and not if the MTD's
parent is hotplugged. In fixing one case you have broken the other.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-07-24 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 17:27 mtd: blktrans: Hotplug fixes Ben Hutchings
2010-07-22 17:44 ` [PATCH 2.6.35] mtd: blktrans: Move device and module ref-counting back to open/release Ben Hutchings
2010-07-24 16:07 ` Maxim Levitsky
2010-07-24 17:03 ` Ben Hutchings [this message]
2010-07-25 7:41 ` Maxim Levitsky
2010-07-27 17:40 ` Ben Hutchings
2010-09-05 23:34 ` Kevin Cernekee
2010-09-07 10:27 ` Artem Bityutskiy
2010-09-07 20:54 ` Maxim Levitsky
2010-09-20 8:30 ` Artem Bityutskiy
2010-09-20 21:47 ` Kevin Cernekee
2010-09-23 21:14 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279991008.4915.7.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).