From: David Woodhouse <dwmw2@infradead.org>
To: dedekind1@gmail.com
Cc: Mike Frysinger <vapier@gentoo.org>,
uclinux-dev@uclinux.org, Bernd Schmidt <bernds_cb1@t-online.de>,
David Howells <dhowells@redhat.com>,
Paul Mundt <lethal@linux-sh.org>,
linux-mtd@lists.infradead.org, Greg Ungerer <gerg@uclinux.org>,
uclinux-dist-devel@blackfin.uclinux.org,
David McCullough <davidm@snapgear.com>
Subject: Re: [PATCH 1/2] mtd: physmap: add physmap_unmapped_area() for no-mmu XIP
Date: Wed, 04 Aug 2010 10:33:28 +0100 [thread overview]
Message-ID: <1280914408.19499.8.camel@localhost> (raw)
In-Reply-To: <1276352794.19028.122.camel@localhost>
On Sat, 2010-06-12 at 17:26 +0300, Artem Bityutskiy wrote:
> On Sun, 2010-05-23 at 03:30 -0400, Mike Frysinger wrote:
> > From: Bernd Schmidt <bernds_cb1@t-online.de>
> >
> > Currently, romfs XIP doesn't work in flash memory (the kernel crashes
> > with a null pointer dereference). The problem is that the mtd physmap
> > driver isn't setting up a get_unmapped_area pointer for the mtd
> > partitions it creates.
> >
> > Signed-off-by: Bernd Schmidt <bernds_cb1@t-online.de>
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> Pushed both to my l2-mtd-2.6.git / dunno.
I'm confused by the second patch -- isn't this done in add_mtd_device()
already, according to the device type?
You're setting mtd_bdi_ro_mappable indiscriminately for all types of
devices. For flash devices, that can be an issue -- if you schedule a
userspace process while the kernel is writing to the flash, for example.
If you want to allow XIP of writable flash devices, there's more to it
than this.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2010-08-04 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 7:30 [PATCH 1/2] mtd: physmap: add physmap_unmapped_area() for no-mmu XIP Mike Frysinger
2010-05-23 7:30 ` [PATCH 2/2] mtd: physmap: allow maps to be read-only mapped Mike Frysinger
2010-06-12 14:26 ` [PATCH 1/2] mtd: physmap: add physmap_unmapped_area() for no-mmu XIP Artem Bityutskiy
2010-08-04 9:33 ` David Woodhouse [this message]
2010-08-07 23:26 ` [Uclinux-dist-devel] " Mike Frysinger
2010-08-08 11:33 ` David Woodhouse
2010-08-09 7:36 ` Mike Frysinger
2010-08-20 6:17 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280914408.19499.8.camel@localhost \
--to=dwmw2@infradead.org \
--cc=bernds_cb1@t-online.de \
--cc=davidm@snapgear.com \
--cc=dedekind1@gmail.com \
--cc=dhowells@redhat.com \
--cc=gerg@uclinux.org \
--cc=lethal@linux-sh.org \
--cc=linux-mtd@lists.infradead.org \
--cc=uclinux-dev@uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).