From: Maxime Bizon <mbizon@freebox.fr>
To: dedekind1@gmail.com
Cc: David Woodhouse <dwmw2@infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Matthieu CASTET <matthieu.castet@parrot.com>,
Brian Norris <norris@broadcom.com>,
Florian Fainelli <ffainelli@freebox.fr>
Subject: Re: [PATCH] NAND: add support for reading ONFI parameters from NAND device
Date: Thu, 05 Aug 2010 14:56:13 +0200 [thread overview]
Message-ID: <1281012973.12446.273.camel@sakura.staff.proxad.net> (raw)
In-Reply-To: <1280984059.1175.13.camel@localhost.localdomain>
On Thu, 2010-08-05 at 07:54 +0300, Artem Bityutskiy wrote:
> On Thu, 2010-07-29 at 00:47 +0200, Florian Fainelli wrote:
> > A nand_chip which has valid ONFI parameters gets its options field updated
> > with the NAND_ONFI flag. In that case both the ONFI version (in BCD format)
> > as well as the complete page parameters is available in the struct nand_chip.
> > This allows for better detection of some new devices, as well as fine tuning of
> > NAND driver timings. This patch only adds support for ONFI 1.0 parameters.
> >
> > Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> > Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
>
> I assume you will send v2 of this patch, so not taking this one.
Please don't
We still need to address all remarks Matthieu did, and of course gives
this more testing (this was more an "RFC" than a "PATCH", sorry)
--
Maxime
prev parent reply other threads:[~2010-08-05 12:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 22:47 [PATCH] NAND: add support for reading ONFI parameters from NAND device Florian Fainelli
2010-07-28 23:38 ` Brian Norris
2010-07-29 8:10 ` Florian Fainelli
2010-07-29 7:54 ` Matthieu CASTET
2010-07-29 8:51 ` Florian Fainelli
2010-08-02 9:25 ` Matthieu CASTET
2010-08-02 11:55 ` Florian Fainelli
2010-08-09 9:25 ` Matthieu CASTET
2010-08-09 9:43 ` Florian Fainelli
2010-08-05 4:54 ` Artem Bityutskiy
2010-08-05 12:56 ` Maxime Bizon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281012973.12446.273.camel@sakura.staff.proxad.net \
--to=mbizon@freebox.fr \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ffainelli@freebox.fr \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
--cc=norris@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox