linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
	linux-mtd@lists.infradead.org, Barry Song <barry.song@analog.com>
Subject: Re: [PATCH 4/7] mtd: Blackfin NFC: wait for the ECC reset to finish
Date: Thu, 05 Aug 2010 16:16:02 +0100	[thread overview]
Message-ID: <1281021362.8720.6.camel@localhost> (raw)
In-Reply-To: <1281020864-26842-4-git-send-email-vapier@gentoo.org>

On Thu, 2010-08-05 at 11:07 -0400, Mike Frysinger wrote:
> 
> +       while (bfin_read_NFC_RST() & ECC_RST)
> +               cpu_relax(); 

All applied, but I'd be happier if this one had some kind of timeout and
didn't have the potential to loop forever if the hardware misbehaves.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

  reply	other threads:[~2010-08-05 15:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-05 15:07 [PATCH 1/7] mtd: Blackfin NFC: fix nand busy detection Mike Frysinger
2010-08-05 15:07 ` [PATCH 2/7] mtd: Blackfin NFC: delete useless comment about jffs2 Mike Frysinger
2010-08-05 15:07 ` [PATCH 3/7] mtd: Blackfin NFC: fix typo for read/write delay setup Mike Frysinger
2010-08-05 15:07 ` [PATCH 4/7] mtd: Blackfin NFC: wait for the ECC reset to finish Mike Frysinger
2010-08-05 15:16   ` David Woodhouse [this message]
2010-08-05 15:20     ` [Uclinux-dist-devel] " Mike Frysinger
2010-08-16  2:54     ` Barry Song
2010-08-16  3:31       ` Mike Frysinger
2010-08-05 15:07 ` [PATCH 5/7] mtd: Blackfin NFC: make sure to check NAND_ALE in cmd_ctrl Mike Frysinger
2010-08-05 15:07 ` [PATCH 6/7] mtd: Blackfin NFC: fix handling of page sizes Mike Frysinger
2010-08-05 15:07 ` [PATCH 7/7] mtd: Blackfin NFC: fix raw page write/read handling Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281021362.8720.6.camel@localhost \
    --to=dwmw2@infradead.org \
    --cc=barry.song@analog.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).