From: David Woodhouse <dwmw2@infradead.org>
To: Chuanxiao <chuanxiao.dong@gmail.com>
Cc: chuanxiao.dong@intel.com, hang.yuan@intel.com,
linux-mtd@lists.infradead.org, yunpeng.gao@intel.com,
dedekind1@gmail.com
Subject: Re: [PATCH v1 2/2]nand/denali Update get_nand_para functions
Date: Thu, 05 Aug 2010 17:34:55 +0100 [thread overview]
Message-ID: <1281026095.8720.29.camel@localhost> (raw)
In-Reply-To: <20100805162800.GC3160@infernal>
On Fri, 2010-08-06 at 00:28 +0800, Chuanxiao wrote:
> @@ -1732,24 +1699,18 @@ static void denali_cmdfunc(struct mtd_info *mtd, unsigned int cmd, int col,
> break;
> case NAND_CMD_READID:
> reset_buf(denali);
> - if (denali->flash_bank < denali->total_used_banks) {
> - /* write manufacturer information into nand
> - buffer for NAND subsystem to fetch.
> - */
> - write_byte_to_buf(denali,
> - denali->dev_info.wDeviceMaker);
> - write_byte_to_buf(denali,
> - denali->dev_info.wDeviceID);
> - write_byte_to_buf(denali,
> - denali->dev_info.bDeviceParam0);
> - write_byte_to_buf(denali,
> - denali->dev_info.bDeviceParam1);
> - write_byte_to_buf(denali,
> - denali->dev_info.bDeviceParam2);
> - } else {
> - int i;
> - for (i = 0; i < 5; i++)
> - write_byte_to_buf(denali, 0xff);
> + /*sometimes ManufactureId read from register is not right
> + * e.g. some of Micron MT29F32G08QAA MLC NAND chips
> + * So here we send READID cmd to NAND insteand
> + * */
> + addr = (uint32_t)MODE_11 | BANK(denali->flash_bank);
drivers/mtd/nand/denali.c: In function ‘denali_cmdfunc’:
drivers/mtd/nand/denali.c:1706: error: ‘addr’ undeclared (first use in this function)
drivers/mtd/nand/denali.c:1706: error: (Each undeclared identifier is reported only once
drivers/mtd/nand/denali.c:1706: error: for each function it appears in.)
drivers/mtd/nand/denali.c:1709: error: ‘i’ undeclared (first use in this function)
drivers/mtd/nand/denali.c:1712: error: ‘id’ undeclared (first use in this function)
make[3]: *** [drivers/mtd/nand/denali.o] Error 1
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2010-08-05 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 16:28 [PATCH v1 2/2]nand/denali Update get_nand_para functions Chuanxiao
2010-08-05 16:34 ` David Woodhouse [this message]
2010-08-05 17:18 ` Chuanxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281026095.8720.29.camel@localhost \
--to=dwmw2@infradead.org \
--cc=chuanxiao.dong@gmail.com \
--cc=chuanxiao.dong@intel.com \
--cc=dedekind1@gmail.com \
--cc=hang.yuan@intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=yunpeng.gao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).