From: David Woodhouse <dwmw2@infradead.org>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Haojian Zhuang <hzhuang1@marvell.com>,
Lei Wen <leiwen@marvell.com>, Axel Lin <axel.lin@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8
Date: Mon, 16 Aug 2010 14:05:19 +0100 [thread overview]
Message-ID: <1281963920.21549.81.camel@localhost> (raw)
In-Reply-To: <AANLkTimjKThiuNPhVyOh-SL1e7Zwu2R8Sd2DXAFixpY+@mail.gmail.com>
On Mon, 2010-08-16 at 20:55 +0800, Eric Miao wrote:
> On Mon, Aug 16, 2010 at 8:49 PM, Haojian Zhuang <hzhuang1@marvell.com> wrote:
> > http://lists.infradead.org/pipermail/linux-mtd/2010-July/subject.html
> >
> > They're re-posted in July. Please search the subjects in that page. They're totally 29 patches.
> >
> > By the way, David, what's the result of review on these patches? We already posted for several times.
> >
>
> I've actually reviewed some of the patches and gave my Ack. For those
> patches, I think they can be merged early.
>
> And overall, they look good. Yet 29 patch in a whole is still a bit too
> much, would be good to see them logically be separated into several
> patch series.
You had some criticism of patch #1 in the sequence, and some questions.
I didn't look much harder than that, iirc... although looking back now
it seems that the rest of your responses to the sequence were largely
positive.
Are you happy with the first patch, and if so shall I go ahead and
import the whole sequence with your Acked-By:?
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2010-08-16 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 8:50 [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8 Axel Lin
2010-08-16 12:22 ` Eric Miao
2010-08-16 12:34 ` Lei Wen
2010-08-16 12:44 ` Eric Miao
2010-08-16 12:49 ` Haojian Zhuang
2010-08-16 12:55 ` Eric Miao
2010-08-16 13:05 ` David Woodhouse [this message]
2010-08-16 13:55 ` Eric Miao
2010-08-16 14:03 ` Lei Wen
2010-08-16 14:16 ` Eric Miao
2010-08-16 14:20 ` Lei Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281963920.21549.81.camel@localhost \
--to=dwmw2@infradead.org \
--cc=axel.lin@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=hzhuang1@marvell.com \
--cc=leiwen@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox