From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: "Stanley.Miao" <stanley.miao@windriver.com>,
linux-mtd@lists.infradead.org, joakim.tjernlund@transmode.se,
Artem.Bityutskiy@nokia.com
Subject: Re: [PATCH v3] Fix mtd-utils bugs
Date: Fri, 20 Aug 2010 08:29:28 +0300 [thread overview]
Message-ID: <1282282168.2183.2.camel@brekeke> (raw)
In-Reply-To: <20100623151622.GA2771@localhost.localdomain>
On Wed, 2010-06-23 at 17:16 +0200, Ladislav Michl wrote:
> On Sun, Jun 20, 2010 at 08:22:57PM +0800, Stanley.Miao wrote:
> > Changes from V2:
> > 1, Get the linux version via uname() according to Joakim Tjernlund.
> > 2, Set the default version the latest version according to Joakim Tjernlund.
> >
> > The "struct nand_oobinfo" is able to record only 32 ECC code positions,which
> > is not enough for many big NAND chips. Therefore, this structure is replaced
> > by "struct nand_ecclayout" in linux kernel from the version 2.6.17.
> > Consequently, the ioctl command changed from MEMGETOOBSEL to ECCGETLAYOUT.
> >
> > Now update nandwrite to use the new ioctl command ECCGETLAYOUT. In order to
> > keep compatible with the old linux kernel, a linux version detection function
> > is added.
> >
> > YAFFS and JFFS2 has updated and we don't need the arguments "forcelegacy",
> > "forcejffs2", "forceyaffs" anymore. Now clean them up.
>
> Tested with linux-2.6.32 (flash_eraseall -j finaly works now)
>
> Tested-by: Ladislav Michl <ladis@linux-mips.org>
>
> As a special bonus, here is simple patch on top of your patchset making
> flash_eraseall smaller:
>
FYI, this patch is still sitting in my mailbox and waiting - Stanley's
stuff was not merged, and this patch depends on that. So, if you can
make it to be independent, please, re-send. Stanley said he'd re-send
the patch.
But also there is some ongoing discussion to deprecate ECCGETLAYOUT, but
I did not read it yet.
Artem.
next prev parent reply other threads:[~2010-08-20 5:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-20 12:22 [PATCH v3] Fix mtd-utils bugs Stanley.Miao
2010-06-20 12:22 ` [PATCHv3 1/3] clean up the legacy interfaces in nandwrite.c Stanley.Miao
2010-06-20 12:22 ` [PATCHv3 2/3] Discard the legacy interface MEMGETOOBSEL in flash_eraseall Stanley.Miao
2010-06-20 12:23 ` [PATCHv3 3/3] Place the cleanmarker in OOB area according to the mode MTD_OOB_AUTO Stanley.Miao
2010-06-22 8:35 ` [PATCH v3] Fix mtd-utils bugs stanley.miao
2010-06-23 13:18 ` Artem Bityutskiy
2010-06-23 15:16 ` Ladislav Michl
2010-08-20 5:29 ` Artem Bityutskiy [this message]
2010-08-20 13:03 ` Ladislav Michl
2010-08-30 10:42 ` Artem Bityutskiy
2010-07-08 6:47 ` Artem Bityutskiy
2010-07-08 7:10 ` stanley.miao
2010-07-18 8:40 ` Artem Bityutskiy
2010-08-04 7:04 ` Artem Bityutskiy
2010-08-04 7:33 ` stanley.miao
-- strict thread matches above, loose matches on Subject: below --
2010-06-18 10:32 Stanley.Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282282168.2183.2.camel@brekeke \
--to=dedekind1@gmail.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=joakim.tjernlund@transmode.se \
--cc=ladis@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=stanley.miao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox