Re: [Uclinux-dist-devel] [PATCH] mtd: Blackfin NFC: fix invalid free in remove()

Mike Frysinger
2010-08-30T15:15:03Z

On Mon, Aug 30, 2010 at 11:10, Artem Bityutskiy wrote:
> On Mon, 2010-08-30 at 09:32 -0400, Mike Frysinger wrote:
>> On Mon, Aug 30, 2010 at 08:59, Artem Bityutskiy wrote:
>> > On Mon, 2010-08-30 at 15:58 +0300, Artem Bityutskiy wrote:
>> >> On Sat, 2010-08-28 at 16:42 -0400, Mike Frysinger wrote:
>> >> > Since info->mtd isn't dynamically allocated, we shouldn't attempt to
>> >> > kfree() it.  Otherwise we get random fun corruption when unloading
>> >> > the driver built as a module.
>> >> >
>> >> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>> >> > ---
>> >> > note: this should be merged for 2.6.36 and probably sent to stable trees
>> >>
>> >> You send the same patch 2 times once with this note and the other time
>> >> without this note. Which one should be ignored?
>> >
>> > I guess it is 2.6.36 material. Also, if you want this in -stable, add
>> > corresponding CC please.
>>
>> once it gets merged, then i can notify the stable guys
>
> AFAIK, this is not the way they prefer to work. The right protocol is
> that you add 'Cc: stable@kernel.org' to the commit message, ane they
> pick the patch. I might be mistaken, but AFAIK this is the way.

np ... i'm not claiming to know more than you ;)
-mike