Re: [PATCH v3] Fix mtd-utils bugs

Artem Bityutskiy
2010-07-08T06:52:39Z

On Sun, 2010-06-20 at 20:22 +0800, Stanley.Miao wrote:
> Changes from V2:
> 1, Get the linux version via uname() according to Joakim Tjernlund.
> 2, Set the default version the latest version according to Joakim Tjernlund.
>
> The "struct nand_oobinfo" is able to record only 32 ECC code positions,which
> is not enough for many big NAND chips. Therefore, this structure is replaced
> by "struct nand_ecclayout" in linux kernel from the version 2.6.17.
> Consequently, the ioctl command changed from MEMGETOOBSEL to ECCGETLAYOUT.
>
> Now update nandwrite to use the new ioctl command ECCGETLAYOUT. In order to
> keep compatible with the old linux kernel, a linux version detection function
> is added.
>
> YAFFS and JFFS2 has updated and we don't need the arguments "forcelegacy",
> "forcejffs2", "forceyaffs" anymore. Now clean them up.

Stanley,

I'd like to first take patches from Kevin, which move libmtd from
ubi-utils and make mtd utilities like flash_eraseall start using libmtd.

It would be nice then if you enhanced limbtd to serve your perposes and
also used it, instead of direct ioctl calls. libmtd should also be used
to get information about which features are supported.

Will this upset you much :-) ?

You can find Kevin's patches I refer in the MTD miling list. The last
series to the date are:

[PATCHv2 1/5] mtd-utils: move libmtd source files to lib/ subdirectory

Could you please take a look at them, review them, then when everyone is
happy, we merge them to mtd-utils, then you can do your changes on top,
and we also add the patch from Ladislav on top.

Does this sound OK for you?

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)