From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <norris@broadcom.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Kevin Cernekee <cernekee@gmail.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] mtd: nand: Support new Toshiba SLC
Date: Mon, 30 Aug 2010 15:27:35 +0300 [thread overview]
Message-ID: <1283171255.12995.54.camel@brekeke> (raw)
In-Reply-To: <1282332973-12077-1-git-send-email-norris@broadcom.com>
On Fri, 2010-08-20 at 12:36 -0700, Brian Norris wrote:
> Toshiba does not use ONFI for their NAND flash. So we have to continue
> to add new IDs used by Toshiba devices as well as heuristic detection
> for scanning the 2nd page for a BBM. This is a relatively harmless
> start at supporting many of them.
>
> These chips mostly follow the same ID fields of previous generations,
> but there is a need for a few tweaks:
>
> * These chips introduce a strange 576 byte OOB (that's 36 bytes per
> 512 bytes of page). In the preliminary data, Toshiba has not
> defined exactly how their ID strings should decode. In the future,
> a new tweak must be added.
> * NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE should be increased soon.
>
> Data is taken from, among others, Toshiba TC58TxG4S2FBAxx
>
> Signed-off-by: Brian Norris <norris@broadcom.com>
> ---
> drivers/mtd/nand/nand_base.c | 5 +++--
> drivers/mtd/nand/nand_ids.c | 31 +++++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+), 2 deletions(-)
Pushed both patches to my l2-mtd-2.6.git / master, but in reverse order,
which seems to be more logical.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2010-08-30 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 19:36 [PATCH 1/2] mtd: nand: Support new Toshiba SLC Brian Norris
2010-08-20 19:36 ` [PATCH 2/2] mtd: nand: Increase NAND_MAX_OOBSIZE Brian Norris
2010-08-20 19:43 ` David Woodhouse
2010-08-20 21:28 ` Brian Norris
2010-08-20 21:38 ` David Woodhouse
2010-08-30 12:27 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283171255.12995.54.camel@brekeke \
--to=dedekind1@gmail.com \
--cc=cernekee@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=norris@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).