From: Artem Bityutskiy <dedekind1@gmail.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>,
Matthieu CASTET <matthieu.castet@parrot.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <norris@broadcom.com>
Subject: Re: [PATCH v2] mtd/nand: Support Micron chips, pagesize >= 4KB
Date: Mon, 30 Aug 2010 15:32:22 +0300 [thread overview]
Message-ID: <1283171542.12995.56.camel@brekeke> (raw)
In-Reply-To: <AANLkTik6657CazQWORXN5fUxancjiUmsQ9ciC035E2T=@mail.gmail.com>
On Wed, 2010-08-25 at 17:43 -0700, Kevin Cernekee wrote:
> > So, I was thinking that adding strange heuristics and quirks to generic
> > code is bad. We should _first_ add proper ONFI code, and _then_ add
> > exception for strange devices like you have.
>
> Unfortunately, I think the heuristic/quirk logic is unavoidable for
> Samsung and other non-ONFI vendors.
>
> So the question becomes: if nand_base.c already has to have
> heuristic/quirk code anyway, and some controller(s) can't speak ONFI
> so they need even MORE heuristic/quirk code than the others - do we
> add the latter code into nand_base.c or just put it in the driver?
OK, I can apply it to the dunno branch and let dwmw2 decide. But this
patch does not apply anymore to to my tree. Brian, would you refresh and
resend? Also, Florian said he is going to send ONFI support soon, may be
it'll make sens to wait a bit and re-send the patch on top of ONFI
support?
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2010-08-30 12:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 20:04 [PATCH] mtd/nand: Support Micron chips, 4KB page Brian Norris
2010-07-27 19:42 ` [PATCH v2] mtd/nand: Support Micron chips, pagesize >= 4KB Brian Norris
2010-07-28 8:36 ` Matthieu CASTET
2010-07-29 23:28 ` Brian Norris
2010-08-22 8:14 ` Artem Bityutskiy
2010-08-22 8:20 ` Artem Bityutskiy
2010-08-22 22:20 ` Kevin Cernekee
2010-08-23 8:22 ` Matthieu CASTET
2010-08-23 21:48 ` Kevin Cernekee
2010-08-24 6:10 ` Artem Bityutskiy
2010-08-26 0:43 ` Kevin Cernekee
2010-08-30 12:32 ` Artem Bityutskiy [this message]
2010-08-05 4:31 ` [PATCH] mtd/nand: Support Micron chips, 4KB page Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283171542.12995.56.camel@brekeke \
--to=dedekind1@gmail.com \
--cc=cernekee@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
--cc=maximlevitsky@gmail.com \
--cc=norris@broadcom.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).