linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Artem.Bityutskiy@nokia.com, linux-mtd@lists.infradead.org,
	dwmw2@infradead.org
Subject: Re: [PATCH 0/3] MTD: OneNAND: Fix OneNAND DMA error handling and 2KiB pagesize
Date: Wed, 01 Sep 2010 02:13:39 +0300	[thread overview]
Message-ID: <1283296419.2018.47.camel@brekeke> (raw)
In-Reply-To: <AANLkTinDPN4bw=2VfwXjKoaXW69m+_oUUq8yH-hvM9oT@mail.gmail.com>

On Tue, 2010-08-31 at 08:27 +0900, Kyungmin Park wrote:
> On Mon, Aug 30, 2010 at 9:52 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > On Fri, 2010-08-27 at 11:55 +0900, Kyungmin Park wrote:
> >> Kyungmin Park (3):
> >>       MTD: OneNAND: Remove unused cmd_map at s5pc110
> >>       MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
> >>       MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCs
> >>
> >>  drivers/mtd/onenand/samsung.c |   17 +++++++----------
> >>  1 files changed, 7 insertions(+), 10 deletions(-)
> >
> > Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1
> > and 3 to l2-mtd-2.6.git / dunno, thanks.
> 
> To David, Artem,
> Can you include these patches to linux-2.6.36-rc4? since it's bug fixes.
> 
> How do you think?

Note, Linus nowadays tends to be stricter about what goes in -rc. Why
would the first patch be a fix deserving urgent merging?

About the second patch, what if you was mistaken and 20msces is not
enough sometimes? Don't you afraid to introduce another bug with this?

Probably for 2.6.36 the older version of your patch can be merged, and
then you can add timeout support on top?

Third patch is probably ok, if you really want it in 2.6.36.

So, I've moved the third patch to l2-mtd-2.6.git / for-2.6.36, I've left
the first patch in the dunno branch, and I also put the original version
of the second patch to the for-2.6.36 branch.

Please, add timeout on top of l2-mtd-2.6.git / for-2.6.36 and send it.
I'll then take care of it, or at least try.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2010-08-31 23:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27  2:55 [PATCH 0/3] MTD: OneNAND: Fix OneNAND DMA error handling and 2KiB pagesize Kyungmin Park
2010-08-30 12:52 ` Artem Bityutskiy
2010-08-30 23:27   ` Kyungmin Park
2010-08-31 23:13     ` Artem Bityutskiy [this message]
2010-09-01  2:35       ` Kyungmin Park
2010-09-01  2:54         ` Kyungmin Park
2010-09-01 10:28         ` Artem Bityutskiy
2010-09-01 10:37           ` Kyungmin Park
2010-09-18 18:29             ` Artem Bityutskiy
2010-09-27 10:09               ` Kyungmin Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283296419.2018.47.camel@brekeke \
    --to=dedekind1@gmail.com \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=dwmw2@infradead.org \
    --cc=kmpark@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).