From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 28/74] Incrementing the ecc_pos array to contain 128 char From: Artem Bityutskiy To: Vipin Kumar In-Reply-To: <4C7CA278.9040902@st.com> References: <07ce8daf18d3a9f13864752074af3490a324d84c.1283161023.git.viresh.kumar@st.com> <1283170469.12995.53.camel@brekeke> <4C7CA278.9040902@st.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 01 Sep 2010 02:36:50 +0300 Message-ID: <1283297810.2018.67.camel@brekeke> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Pratyush ANAND , Viresh KUMAR , Vipul Kumar SAMAR , Bhupesh SHARMA , Armando VISCONTI , Shiraz HASHIM , Rajeev KUMAR , "linux-mtd@lists.infradead.org" , Deepak SIKRI , "dwmw2@infradead.org" , "linux-arm-kernel@lists.infradead.org" Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, On Tue, 2010-08-31 at 12:04 +0530, Vipin Kumar wrote: > > Nack, breaking ABI Is not allowed in Linux. > I could not understand your point. Can you please elaborate. How does this patch > break ABI You are changing data structure (struct nand_ecclayout) used for in MTD ioctl. Tha ioctl is part of the Linux ABI. By changing the data structure, you are breaking the ABI. This means that current binaries would stop working with newer versions of the Linux kernel if we'd accept your patch. -- Best Regards, Artem Bityutskiy (Битюцкий Артём)