From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-fx0-f49.google.com ([209.85.161.49]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Osv6T-0001E5-K0 for linux-mtd@lists.infradead.org; Tue, 07 Sep 2010 10:08:38 +0000 Received: by fxm12 with SMTP id 12so3691457fxm.36 for ; Tue, 07 Sep 2010 03:08:36 -0700 (PDT) Subject: Re: [PATCH] mkfs.ubifs: do not override root inode permissions From: Artem Bityutskiy To: linux-mtd@lists.infradead.org In-Reply-To: <1283850462-4244-1-git-send-email-dedekind1@gmail.com> References: <1283850462-4244-1-git-send-email-dedekind1@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 07 Sep 2010 13:07:06 +0300 Message-ID: <1283854026.2979.28.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Arno Steffen , Adrian Hunter Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2010-09-07 at 12:07 +0300, Artem Bityutskiy wrote: > From: Artem Bityutskiy > > When mkfs.ubifs is used with -r dir, it does not make the root UBIFS > inode uid/gid/permissions to be equivalent to dir's permissions, but > it makes root inode permissions to be equivalent to uid = git = 0 > (root) and permissions = u+rwx go+rx. > > This patch changes the behavior and makes mkfs.ubifs use the > permissions of the directory containing the original files on the host. > I.e., it will be 's uid/git/permissions if case of mkfs.ubifs > -r . > > This patch is a bit dangerous because it changes the behavior and may > have security implications if someone used the older version, relied > on this bug, and upgrades to the newer version. > > Signed-off-by: Artem Bityutskiy Sorry for duplicate. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)