From: Maxim Levitsky <maximlevitsky@gmail.com>
To: dedekind1@gmail.com
Cc: Ben Hutchings <bhutchings@solarflare.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Kevin Cernekee <cernekee@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 2.6.35] mtd: blktrans: Move device and module ref-counting back to open/release
Date: Tue, 07 Sep 2010 23:54:29 +0300 [thread overview]
Message-ID: <1283892869.3407.4.camel@maxim-laptop> (raw)
In-Reply-To: <1283855250.2979.33.camel@localhost>
On Tue, 2010-09-07 at 13:27 +0300, Artem Bityutskiy wrote:
> On Sun, 2010-09-05 at 16:34 -0700, Kevin Cernekee wrote:
> > On Thu, Jul 22, 2010 at 10:44 AM, Ben Hutchings
> > <bhutchings@solarflare.com> wrote:
> > > commit 048d87199566663e4edc4880df3703c04bcf41d9 "mtd: blktrans: Hotplug
> > > fixes" causes the MTD and the MTD driver module's ref-counts to be
> > > bumped for each block device that is created, whether or not it's
> > > actually in use.
> > >
> > > This means that before removing an MTD or driver module one must first
> > > remove all the associated block devices. But the block devices will
> > > be removed only when the MTDs themselves are removed, which is no
> > > longer possible.
> >
> > Just updated to 2.6.36-rc3 and noticed a related issue. Configuration is:
>
> Sounds like a regression which should be either fixed or the patch which
> causes this should be reverted. Maxim?
We have a tough issue here.
The way mtd core is built, it assumes that one can always remove an mtd
device, therefore all users must let it go as soon as asked first time.
Its possible to fix that of course, but I'll need to touch a lot of code
I can't test.
Really mtd core wasn't build with hotplug in the mind.
I'll think of something (and you all are welcome to help).
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2010-09-07 20:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 17:27 mtd: blktrans: Hotplug fixes Ben Hutchings
2010-07-22 17:44 ` [PATCH 2.6.35] mtd: blktrans: Move device and module ref-counting back to open/release Ben Hutchings
2010-07-24 16:07 ` Maxim Levitsky
2010-07-24 17:03 ` Ben Hutchings
2010-07-25 7:41 ` Maxim Levitsky
2010-07-27 17:40 ` Ben Hutchings
2010-09-05 23:34 ` Kevin Cernekee
2010-09-07 10:27 ` Artem Bityutskiy
2010-09-07 20:54 ` Maxim Levitsky [this message]
2010-09-20 8:30 ` Artem Bityutskiy
2010-09-20 21:47 ` Kevin Cernekee
2010-09-23 21:14 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283892869.3407.4.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=cernekee@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox