From: Artem Bityutskiy <dedekind1@gmail.com>
To: Saeed Bishara <saeed@marvell.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] cmd line partitions: use 64 bit variables to detect partitions/offsets larger than 4G.
Date: Wed, 08 Sep 2010 11:31:26 +0300 [thread overview]
Message-ID: <1283934686.2979.58.camel@localhost> (raw)
In-Reply-To: <1283852918-9141-1-git-send-email-saeed@marvell.com>
On Tue, 2010-09-07 at 12:48 +0300, Saeed Bishara wrote:
> Signed-off-by: Saeed Bishara <saeed@marvell.com>
> ---
> drivers/mtd/cmdlinepart.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
> index 1479da6..80036d1 100644
> --- a/drivers/mtd/cmdlinepart.c
> +++ b/drivers/mtd/cmdlinepart.c
> @@ -41,8 +41,8 @@
>
>
> /* special size referring to all the remaining space in a partition */
> -#define SIZE_REMAINING UINT_MAX
> -#define OFFSET_CONTINUOUS UINT_MAX
> +#define SIZE_REMAINING LLONG_MAX
> +#define OFFSET_CONTINUOUS LLONG_MAX
Should be ULLONG_MAX since you use unsigned long long and also offsets
in 'struct mtd_partition' uses uint64_t.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-09-08 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 11:23 [PATCH] cmd line partitions: use 64 bit variables to detect partitions/offsets larger than 4G Saeed Bishara
2010-09-05 13:08 ` [PATCH v2] " Saeed Bishara
2010-09-07 8:56 ` Artem Bityutskiy
2010-09-07 9:48 ` [PATCH] " Saeed Bishara
2010-09-08 8:31 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283934686.2979.58.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=saeed@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).