linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] nandwrite: add --nobad to write bad blocks
Date: Tue, 14 Sep 2010 08:26:07 +0300	[thread overview]
Message-ID: <1284441967.2084.18.camel@brekeke> (raw)
In-Reply-To: <AANLkTin4u=jQOxxuTwzMHrEEg=vDc2TSTah_=_Li02xx@mail.gmail.com>

On Mon, 2010-09-13 at 21:21 -0400, Mike Frysinger wrote:
> so once we have the ability to erase them, you'll merge this ?

Let's see, why not. How about what I suggest below.

> not that i see why we're restricting this behavior in the first place

First of all, bad eraseblock is the eraseblock which should not be used,
because it is bad. Writing to a bad eraseblock should not be allowed.

Your use-case is that an eraseblock is marked as bad incorrectly - by a
mistake or due to some problems.

So what you need is an operation which makes it good again and let's you
use it.

Once you add such operation, you will mark needed eraseblocks as good
again (effectively, erase them, and unmark in in-RAM and/or on-flash
BBD). After this you will not need --nobad option, because the
eraseblock is already good.

> ... policy is for the end user to determine ... this is putting
> artificial limits for no real reason that i can see.

But the problem is not artificial limits. The problem is that I do not
think your option is usable at all, because, as I explained, bad
eraseblock is not necessarily writable, it's contents and the state is
unpredictable. It may contain unstable bits, for example. You really
need to erase it before writing.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2010-09-14  5:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-12  3:51 [PATCH] nandwrite: add --nobad to write bad blocks Mike Frysinger
2010-09-12 16:27 ` Artem Bityutskiy
2010-09-12 19:05   ` Mike Frysinger
2010-09-13  6:23     ` Artem Bityutskiy
2010-09-14  1:21       ` Mike Frysinger
2010-09-14  5:26         ` Artem Bityutskiy [this message]
2010-09-22  4:23           ` Mike Frysinger
2010-09-22  7:12             ` Artem Bityutskiy
2010-09-22  7:34               ` Mike Frysinger
2010-09-29  3:35                 ` Iwo Mergler
2010-09-29  6:56                   ` Jon Povey
2010-09-29 13:25                     ` Mike Frysinger
2010-09-29 23:44                     ` Iwo Mergler
2010-09-30  3:23                       ` Jon Povey
2010-09-29 12:59                   ` Artem Bityutskiy
2010-09-29 13:28                     ` Mike Frysinger
2010-09-30  3:51                       ` Jon Povey
2010-09-23  1:48             ` Jon Povey
2010-09-23 10:38 ` Artem Bityutskiy
2010-09-23 20:04   ` [PATCH v2] " Mike Frysinger
2010-09-24  8:50     ` Artem Bityutskiy
2010-09-24 12:33       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284441967.2084.18.camel@brekeke \
    --to=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).