Re: [PATCH 1/2][MTD]MLC device check in OneNAND driver

[Artem Bityutskiy <dedekind1@gmail.com>]

Hi,

few minor things. I could just do this all myself, but since this is not
the first non-perfect patch you send, I think I'll be a little nasty and
ask you should do the exercise :-)

On Thu, 2010-09-23 at 17:26 +0530, Rohit Hassan Sathyanarayan wrote:
> Hi Artem,
> 
> Adding driver check for MLC flash type.
> 
> 
> Signed-off-by: Rohit HS <rohit.hs@samsung.com>
> Signed-off-by: Raghav Gupta <gupta.raghav@samsung.com>

1. Do no add extra line between the message and signed off.

2. Ideally, your patches should be applicable with git-am without the
   need to edit them. Try git am for your patches and see the result -
   the commit message will contain 'Hi Artem,' phrase, which should not
   be there.

> ---
>  drivers/mtd/onenand/onenand_base.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
> index a2bb520..33e0dbb 100644
> --- a/drivers/mtd/onenand/onenand_base.c
> +++ b/drivers/mtd/onenand/onenand_base.c
> @@ -4027,7 +4027,7 @@ int onenand_scan(struct mtd_info *mtd, int maxchips)
>  	mtd->ecclayout = this->ecclayout;
>  
>  	/* Fill in remaining MTD driver data */
> -	mtd->type = MTD_NANDFLASH;
> +	mtd->type = ONENAND_IS_MLC(this) ? MTD_MLCNANDFLASH : MTD_NANDFLASH;
>  	mtd->flags = MTD_CAP_NANDFLASH;
>  	mtd->erase = onenand_erase;
>  	mtd->point = NULL;

The kernel does not compile with this patch. You should make this patch
the second, the first one should introduce MTD_MLCNANDFLASH.

The kernel has to be bisectable, you patches should not break
bisectability.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)