* [PATCH v2] ubifs: avoid kernel error if ubifs superblock read fails
[not found] <1285577837.16181.14.camel@localhost>
@ 2010-09-27 12:20 ` Steffen Sledz
2010-09-28 6:49 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Steffen Sledz @ 2010-09-27 12:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Steffen Sledz, linux-mtd, Artem Bityutskiy
* .get_sb is called on mounts with automatic fs detection too, so this
function should print an error if it cannot read the superblock in
debug mode only
(new behaviour conforms the other fs types)
Signed-off-by: Steffen Sledz <sledz@dresearch.de>
---
fs/ubifs/super.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 4e5bf3f..bb6ed5d 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -2054,8 +2054,8 @@ static int ubifs_get_sb(struct file_system_type *fs_type, int flags,
*/
ubi = open_ubi(name, UBI_READONLY);
if (IS_ERR(ubi)) {
- ubifs_err("cannot open \"%s\", error %d",
- name, (int)PTR_ERR(ubi));
+ dbg_err("cannot open \"%s\", error %d",
+ name, (int)PTR_ERR(ubi));
return PTR_ERR(ubi);
}
ubi_get_volume_info(ubi, &vi);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ubifs: avoid kernel error if ubifs superblock read fails
2010-09-27 12:20 ` [PATCH v2] ubifs: avoid kernel error if ubifs superblock read fails Steffen Sledz
@ 2010-09-28 6:49 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2010-09-28 6:49 UTC (permalink / raw)
To: Steffen Sledz; +Cc: linux-mtd, linux-kernel
On Mon, 2010-09-27 at 14:20 +0200, Steffen Sledz wrote:
> * .get_sb is called on mounts with automatic fs detection too, so this
> function should print an error if it cannot read the superblock in
> debug mode only
> (new behaviour conforms the other fs types)
>
> Signed-off-by: Steffen Sledz <sledz@dresearch.de>
Pushed to ubifs-2.6.git, thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-28 6:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1285577837.16181.14.camel@localhost>
2010-09-27 12:20 ` [PATCH v2] ubifs: avoid kernel error if ubifs superblock read fails Steffen Sledz
2010-09-28 6:49 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).