From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-bw0-f49.google.com ([209.85.214.49]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1P22tg-0003kw-3u for linux-mtd@lists.infradead.org; Sat, 02 Oct 2010 14:17:08 +0000 Received: by bwz19 with SMTP id 19so3767445bwz.36 for ; Sat, 02 Oct 2010 07:17:07 -0700 (PDT) Subject: Re: [PATCH 2/2] sumtool/libfec: convert "()" to "(void)" in func defs From: Artem Bityutskiy To: Mike Frysinger In-Reply-To: <1285953088-19593-2-git-send-email-vapier@gentoo.org> References: <1285953088-19593-1-git-send-email-vapier@gentoo.org> <1285953088-19593-2-git-send-email-vapier@gentoo.org> Content-Type: text/plain; charset="UTF-8" Date: Sat, 02 Oct 2010 17:17:02 +0300 Message-ID: <1286029022.32172.21.camel@brekeke> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-mtd@lists.infradead.org Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2010-10-01 at 13:11 -0400, Mike Frysinger wrote: > Since these functions take no parameters, declare them as such. The > subtle difference here is that gcc allows (without warning) people to > accidentally call funcs declared with "()" with arguments. Using void > makes sure that gcc will reject such typos at compile time. > > Signed-off-by: Mike Frysinger Pushed, thanks! -- Best Regards, Artem Bityutskiy (Битюцкий Артём)