From: Artem Bityutskiy <dedekind1@gmail.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] nanddump: fix initialization of bad blocks oob data buffer
Date: Tue, 12 Oct 2010 13:02:22 +0300 [thread overview]
Message-ID: <1286877742.2164.40.camel@localhost> (raw)
In-Reply-To: <0870ac8ab250ec91dceb2cc461fe82c0d7995bc8.1286788714.git.baruch@tkos.co.il>
On Mon, 2010-10-11 at 11:19 +0200, Baruch Siach wrote:
> When dumping oob data of a bad block, initialize oobbuf with 0xff, instead of
> readbuf. This avoids bogus oob data on output.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> nanddump.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/nanddump.c b/nanddump.c
> index 3589931..0fdf736 100644
> --- a/nanddump.c
> +++ b/nanddump.c
> @@ -452,7 +452,7 @@ int main(int argc, char * const argv[])
> continue;
>
> if (badblock) {
> - memset (readbuf, 0xff, meminfo.oobsize);
> + memset (oobbuf, 0xff, meminfo.oobsize);
Removed junk white-space
> } else {
> /* Read OOB data and exit on failure */
> oob.start = ofs;
and push to mtd-utils.git, thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-10-12 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 9:19 [PATCH] nanddump: fix initialization of bad blocks oob data buffer Baruch Siach
2010-10-11 17:07 ` Mike Frysinger
2010-10-12 10:02 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286877742.2164.40.camel@localhost \
--to=dedekind1@gmail.com \
--cc=baruch@tkos.co.il \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox