Re: [RFC] do_mounts: Allow mtd names for non-flash block filesystems

[Artem Bityutskiy <dedekind1@gmail.com>]

On Tue, 2010-10-12 at 17:11 +0200, Karl Beldan wrote:
> On Tue, Oct 12, 2010 at 4:27 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > On Tue, 2010-10-12 at 15:16 +0200, Karl Beldan wrote:
> >> On Mon, Oct 11, 2010 at 9:24 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> >> > On Wed, 2010-10-06 at 23:02 +0200, Karl Beldan wrote:
> >> >> Hi,
> >> >>
> >> >> I have been using this tweak for some time now, and I am getting tired of
> >> >> having to resort to it so often.
> >> >> It allows to pass such cmdline root as:
> >> >>  "root=mtdb:ubivolx rootfstype=squashfs"
> >> >> I am pretty sure many people use squashfs/cramfs filesystems on top of nand,
> >> >> for example, and I thought that this might initiate discussion.
> >> >>
> >> >> --
> >> >> Karl
> >> >>
> >> >> Signed-off-by: Karl Beldan <karl.beldan@gmail.com>
> >> >> ---
> >> >>  init/do_mounts.c |   15 +++++++++++++--
> >> >>  1 files changed, 13 insertions(+), 2 deletions(-)
> >> >
> >> > Dunno...
> >> >
> >> > First of all, if you have to do this, let it be mtdblock, not mtdb - no
> >> > need to breed aliases.
> >> >
> >> > But how about teaching squashfs to understand mtdX and mtd:name syntax
> >> > instead?
> >> >
> >>
> >> Hi Artem,
> >>
> >> I would not do that, squashfs and co just ask for a block device, putting mtdx
> >> syntax awareness in each of them just does not seem a good fit to me.
> >
> > Right. But the same arguments applies to do_mounts.c which you hack:
> To a far lesser extent, moreover do_mounts has similar hacks in that
> regard, plus doing
> this into squashfs you would have to do it everywhere else (e.g cramfs).
> I just cannot agree, sorry.

No, they are not similar. They are for devices of different type, not
for _block_ devices. So those are about adding base support for MTD and
UBI devices.

In your case this is about block devices, which are already supported.
What you do is you say - mtd block devices are very special, they should
have own hack. Why not scsii block devices or any other types?

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)