linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: OneNAND: S5PC110: Fix double call suspend & resume function
@ 2010-10-20  8:31 Kyungmin Park
  2010-10-21  8:57 ` Artem Bityutskiy
  0 siblings, 1 reply; 2+ messages in thread
From: Kyungmin Park @ 2010-10-20  8:31 UTC (permalink / raw)
  To: linux-mtd; +Cc: Artem.Bityutskiy, dwmw2

From: Kyungmin Park <kyungmin.park@samsung.com>

The suspend & resume called from mtd core. So no need to call at driver.

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---

diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c
index 214ed1e..0de7a05 100644
--- a/drivers/mtd/onenand/samsung.c
+++ b/drivers/mtd/onenand/samsung.c
@@ -1098,7 +1098,7 @@ static int s3c_pm_ops_suspend(struct device *dev)
 	struct onenand_chip *this = mtd->priv;
 
 	this->wait(mtd, FL_PM_SUSPENDED);
-	return mtd->suspend(mtd);
+	return 0;
 }
 
 static  int s3c_pm_ops_resume(struct device *dev)
@@ -1107,7 +1107,6 @@ static  int s3c_pm_ops_resume(struct device *dev)
 	struct mtd_info *mtd = platform_get_drvdata(pdev);
 	struct onenand_chip *this = mtd->priv;
 
-	mtd->resume(mtd);
 	this->unlock_all(mtd);
 	return 0;
 }

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: OneNAND: S5PC110: Fix double call suspend & resume function
  2010-10-20  8:31 [PATCH] mtd: OneNAND: S5PC110: Fix double call suspend & resume function Kyungmin Park
@ 2010-10-21  8:57 ` Artem Bityutskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2010-10-21  8:57 UTC (permalink / raw)
  To: Kyungmin Park; +Cc: dwmw2, linux-mtd

On Wed, 2010-10-20 at 17:31 +0900, Kyungmin Park wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
> 
> The suspend & resume called from mtd core. So no need to call at driver.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Pushed this one to my l2 tree, thanks!

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-10-21  9:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-20  8:31 [PATCH] mtd: OneNAND: S5PC110: Fix double call suspend & resume function Kyungmin Park
2010-10-21  8:57 ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).