From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-fx0-f49.google.com ([209.85.161.49]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1P8sS2-0004Rv-PY for linux-mtd@lists.infradead.org; Thu, 21 Oct 2010 10:32:52 +0000 Received: by fxm15 with SMTP id 15so3637236fxm.36 for ; Thu, 21 Oct 2010 03:32:48 -0700 (PDT) Subject: Re: [PATCH] mtd: Apply Numonyx Axcell P33/P30 workaround for Lock/Unlock bug. From: Artem Bityutskiy To: Philippe De Muyter In-Reply-To: <20101021093343.GA17631@frolo.macqel> References: <1287498263-5561-1-git-send-email-phdm@macqel.be> <1287650398.2932.5.camel@localhost> <20101021093343.GA17631@frolo.macqel> Content-Type: text/plain; charset="UTF-8" Date: Thu, 21 Oct 2010 13:29:43 +0300 Message-ID: <1287656983.2932.14.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-mtd@lists.infradead.org, Nicolas Pitre Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2010-10-21 at 11:33 +0200, Philippe De Muyter wrote: > On Thu, Oct 21, 2010 at 11:39:58AM +0300, Artem Bityutskiy wrote: > > On Tue, 2010-10-19 at 16:24 +0200, Philippe De Muyter wrote: > > > Some flash chips have a small but annoying bug, documented in > > > "Numonyx Axcell P33/P30 256-Mbit Specification Update" > > > > > > It states : > > > When customer uses [...] block unlock, the block lock status might > > > be altered inadvertently. Lock status might be set to either 01h > > > or 03h unexpectedly (00h as expected data), which leads to > > > program/erase failure on certain blocks. > > > > > > A workaround is given, (summary : issue a "Read Lock Status" before > > > the "Lock" or "Unlock" command) which I have applied and tested > > > with success. > > > > > > Signed-off-by: Philippe De Muyter > > > > Is this Numonyx-specific issue? Should there be some kind of "if > > (numonyx)" statement? > > This is clearly a bug specific to some Numonyx flashes. > My chips have Manufacturer ID: 0x89, Device ID: 0x881B, but there are > other chips in the same family. The errata > http://www.numonyx.com/Documents/Specification%20Updates/509003_P3X_65nm_3V_256Mbit_Discrete.pdf does not list the ManufacturerIDs/DeviceIDs of the affected > chips. CCed Nicolas correctly. Anyway, if this affects only subset of chips, it make sense to make this quirk conditional, because this might affect boot speed, e.g., if some systems unlock all blocks on boot-up. Nicolas, the original patch was here, would you validate it please? http://lists.infradead.org/pipermail/linux-mtd/2010-October/032783.html -- Best Regards, Artem Bityutskiy (Артём Битюцкий)