From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Jörn Engel" <joern@logfs.org>
Cc: Nicolas Kaiser <nikai@nikai.net>,
linux-mtd@lists.infradead.org,
Joern Engel <joern@lazybastard.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block2mtd: dubious assignment
Date: Fri, 22 Oct 2010 19:13:50 +0300 [thread overview]
Message-ID: <1287764030.7480.1.camel@brekeke> (raw)
In-Reply-To: <20101022143416.GA12737@logfs.org>
On Fri, 2010-10-22 at 16:34 +0200, Jörn Engel wrote:
> On Fri, 22 October 2010 12:47:24 +0200, Nicolas Kaiser wrote:
> >
> > When block2mtd_erase fails, a duplicated assignment instantly
> > changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.
> >
> > It looks to me like this might not be intended, or is it?
>
> Definitely not. Just proves how well block device errors are tested.
>
> > Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> Acked-By: Joern Engel <joern@logfs.org>
>
> Artem, can I leave this patch to you as well?
Yes, I'll put it to my l2 tree of course, thanks.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2010-10-22 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 10:47 [PATCH] block2mtd: dubious assignment Nicolas Kaiser
2010-10-22 14:34 ` Jörn Engel
2010-10-22 16:13 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287764030.7480.1.camel@brekeke \
--to=dedekind1@gmail.com \
--cc=joern@lazybastard.org \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).