From: Artem Bityutskiy <dedekind1@gmail.com>
To: Matthieu CASTET <matthieu.castet@parrot.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [RFC] write bad block marker even with BBT
Date: Mon, 25 Oct 2010 11:05:45 +0300 [thread overview]
Message-ID: <1287993945.2224.9.camel@localhost> (raw)
In-Reply-To: <4CC1A5EE.9080605@parrot.com>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index ddffe76..71052d0 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -409,7 +409,10 @@ static int nand_default_block_markbad(struct mtd_info *mtd, loff_t ofs)
> /* Do we have a flash based bad block table ? */
> if (chip->options & NAND_USE_FLASH_BBT)
> ret = nand_update_bbt(mtd, ofs);
> - else {
> + /* put also the bad block marker in case we loose BBT or
> + the bootloader doesn't support reading it
> + */
Nitpick: please, use kernel commenting style:
/*
* Multi-line
* comment
*/
> + {
> nand_get_device(chip, mtd, FL_WRITING);
I think this makes sense, but this may break some setups, so this should
be yet another chip->option.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-10-25 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 14:55 [RFC] write bad block marker even with BBT Matthieu CASTET
2010-10-25 8:05 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287993945.2224.9.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).