From: David Woodhouse <david.woodhouse@intel.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"zhangyd6@gmail.com" <zhangyd6@gmail.com>,
"fggs@terra.com.br" <fggs@terra.com.br>,
Guillaume LECERF <glecerf@gmail.com>
Subject: Re: [PATCH 2 2/3] mtd: cfi_cmdset_0002: add CFI detection for SST 38VF640x chips
Date: Tue, 26 Oct 2010 11:29:17 +0100 [thread overview]
Message-ID: <1288088957.29264.24.camel@macbook.infradead.org> (raw)
In-Reply-To: <20101026102548.GB31843@pengutronix.de>
On Tue, 2010-10-26 at 11:25 +0100, Wolfram Sang wrote:
> > + /*
> > + * CFI reports 1024 sectors (0x03ff +1) of 64KBytes (0x0100 *256) where
> > + * it should report a size of 8KBytes (0x0020 *256).
>
> Spaces after operators?
>
> > + */
> > + cfi->cfiq->EraseRegionInfo[0] = 0x002003ff;
> > + pr_warning("%s: Bad 38VF640x CFI data, adjust sector size from 64 to 8KBytes\n", mtd->name);
>
> Should be "adjusting", otherwise it sounds like a task for the user to do.
And s/KBytes/KiB/ while we're nitpicking.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2010-10-26 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 9:26 [PATCH 2 1/3] mtd: cfi_util: add support for switching SST 39VF640xB chips into QRY mode Guillaume LECERF
2010-10-26 9:26 ` [PATCH 2 2/3] mtd: cfi_cmdset_0002: add CFI detection for SST 38VF640x chips Guillaume LECERF
2010-10-26 10:25 ` Wolfram Sang
2010-10-26 10:29 ` David Woodhouse [this message]
2010-10-26 9:26 ` [PATCH 2 3/3] mtd: cfi_cmdset_0002: make sector erase command variable Guillaume LECERF
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288088957.29264.24.camel@macbook.infradead.org \
--to=david.woodhouse@intel.com \
--cc=fggs@terra.com.br \
--cc=glecerf@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=w.sang@pengutronix.de \
--cc=zhangyd6@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).