linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: OneNAND: Fix page offset handling at 2KiB pagesize
@ 2010-11-02  1:28 Kyungmin Park
  2010-11-13 10:51 ` Artem Bityutskiy
  0 siblings, 1 reply; 2+ messages in thread
From: Kyungmin Park @ 2010-11-02  1:28 UTC (permalink / raw)
  To: linux-mtd; +Cc: dwmw2, dedekind1

From: Kyungmin Park <kyungmin.park@samsung.com>

When use the 2KiB pagesize, it should be set the correct page offset.

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c
index 0de7a05..a4c74a9 100644
--- a/drivers/mtd/onenand/samsung.c
+++ b/drivers/mtd/onenand/samsung.c
@@ -651,7 +651,7 @@ static int s5pc110_read_bufferram(struct mtd_info *mtd, int area,
 	void __iomem *p;
 	void *buf = (void *) buffer;
 	dma_addr_t dma_src, dma_dst;
-	int err, page_dma = 0;
+	int err, ofs, page_dma = 0;
 	struct device *dev = &onenand->pdev->dev;
 
 	p = this->base + area;
@@ -677,10 +677,13 @@ static int s5pc110_read_bufferram(struct mtd_info *mtd, int area,
 		if (!page)
 			goto normal;
 
+		/* Page offset */
+		ofs = ((size_t) buf & ~PAGE_MASK);
 		page_dma = 1;
+
 		/* DMA routine */
 		dma_src = onenand->phys_base + (p - this->base);
-		dma_dst = dma_map_page(dev, page, 0, count, DMA_FROM_DEVICE);
+		dma_dst = dma_map_page(dev, page, ofs, count, DMA_FROM_DEVICE);
 	} else {
 		/* DMA routine */
 		dma_src = onenand->phys_base + (p - this->base);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: OneNAND: Fix page offset handling at 2KiB pagesize
  2010-11-02  1:28 [PATCH] mtd: OneNAND: Fix page offset handling at 2KiB pagesize Kyungmin Park
@ 2010-11-13 10:51 ` Artem Bityutskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2010-11-13 10:51 UTC (permalink / raw)
  To: Kyungmin Park; +Cc: dwmw2, linux-mtd

On Tue, 2010-11-02 at 10:28 +0900, Kyungmin Park wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
> 
> When use the 2KiB pagesize, it should be set the correct page offset.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Pushed to l2-mtd-2.6.git, thank you.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-11-13 10:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-02  1:28 [PATCH] mtd: OneNAND: Fix page offset handling at 2KiB pagesize Kyungmin Park
2010-11-13 10:51 ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).