* [PATCH 1/1] [MTD]:CORE Fix wrong check register_blkdev return value
@ 2010-11-10 10:52 Frank Li
2010-11-26 15:43 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Frank Li @ 2010-11-10 10:52 UTC (permalink / raw)
To: linux-mtd; +Cc: Frank Li, dwmw2, linux-kernel.vger.kernel.org
register_blkdev return 1..255 when major = 0.
if (ret ) {
printk(KERN_WARNING "Unable to register %s block device on major %d: %d\n",
tr->name, tr->major, ret);
mutex_unlock(&mtd_table_mutex);
return ret;
}
Above code will return fail when register_blkdev return allocated major number.
Signed-off-by: Frank Li <Frank.Li@freescale.com>
---
drivers/mtd/mtd_blkdevs.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index a919587..63790e9 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -502,13 +502,16 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *tr)
mutex_lock(&mtd_table_mutex);
ret = register_blkdev(tr->major, tr->name);
- if (ret) {
+ if (ret < 0) {
printk(KERN_WARNING "Unable to register %s block device on major %d: %d\n",
tr->name, tr->major, ret);
mutex_unlock(&mtd_table_mutex);
return ret;
}
+ if (ret)
+ tr->major = ret;
+
tr->blkshift = ffs(tr->blksize) - 1;
INIT_LIST_HEAD(&tr->devs);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] [MTD]:CORE Fix wrong check register_blkdev return value
2010-11-10 10:52 [PATCH 1/1] [MTD]:CORE Fix wrong check register_blkdev return value Frank Li
@ 2010-11-26 15:43 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2010-11-26 15:43 UTC (permalink / raw)
To: Frank Li; +Cc: dwmw2, linux-mtd, linux-kernel.vger.kernel.org
On Wed, 2010-11-10 at 18:52 +0800, Frank Li wrote:
> register_blkdev return 1..255 when major = 0.
>
> if (ret ) {
> printk(KERN_WARNING "Unable to register %s block device on major %d: %d\n",
> tr->name, tr->major, ret);
> mutex_unlock(&mtd_table_mutex);
> return ret;
> }
>
> Above code will return fail when register_blkdev return allocated major number.
>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
This patch is already in upstream.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-26 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-10 10:52 [PATCH 1/1] [MTD]:CORE Fix wrong check register_blkdev return value Frank Li
2010-11-26 15:43 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).