From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mms2.broadcom.com ([216.31.210.18]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PNgsb-0000iB-9X for linux-mtd@lists.infradead.org; Wed, 01 Dec 2010 07:13:29 +0000 From: "Brian Norris" To: linux-mtd@lists.infradead.org Subject: [PATCH v3 5/8] nanddump: check for negative inputs Date: Tue, 30 Nov 2010 23:12:30 -0800 Message-ID: <1291187550-17545-1-git-send-email-computersforpeace@gmail.com> References: <1291184303-4596-1-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1291184303-4596-1-git-send-email-computersforpeace@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Brian Norris , David Woodhouse , Mike Frysinger , Artem Bityutskiy List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Includes error messages for negative device offsets and negative lengths, telling the user what the offending option and value were. Previous patch left out the "negative" in the error message. Signed-off-by: Brian Norris --- nanddump.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/nanddump.c b/nanddump.c index b0dd7dc..6a6f904 100644 --- a/nanddump.c +++ b/nanddump.c @@ -173,6 +173,13 @@ static void process_options(int argc, char * const argv[]) } } + if (start_addr < 0) + errmsg_die("Can't specify negative offset with option -s: %lld", + start_addr); + + if (length < 0) + errmsg_die("Can't specify negative length with option -l: %lld", length); + if (quiet && pretty_print) { fprintf(stderr, "The quiet and pretty print options are mutually-\n" "exclusive. Choose one or the other.\n"); -- 1.7.0.4