From: Artem Bityutskiy <dedekind1@gmail.com>
To: Anatolij Gustschin <agust@denx.de>
Cc: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 1/6] mtd: add writebufsize field to mtd_info struct
Date: Sun, 19 Dec 2010 19:45:31 +0200 [thread overview]
Message-ID: <1292780731.13362.16.camel@koala> (raw)
In-Reply-To: <1292539339-25111-2-git-send-email-agust@denx.de>
On Thu, 2010-12-16 at 23:42 +0100, Anatolij Gustschin wrote:
> This field will be used to indicate the write buffer size
> of the MTD device. UBI will set it's minimal I/O unit size
> (min_io_size) to the indicated write buffer size. By this
> change we intend to fix failed recovery of UBIFS partitions
> we currently observe on NOR flash when mounting the partition
> after unclean unmount.
>
> Currently the min_io_size is set to mtd->writesize (which is 1
> byte for NOR flash). But flash programming is often done from
> prepared write buffer containing multiple bytes and is performed
> in one programming operation which could be interrupted by a power
> cut or a system reset causing corrupted (partially written) areas
> in a flash sector. Knowing the size of potentially corrupted areas
> UBIFS scanning and recovery algorithms are able to perform
> successful recovery.
>
> In case of NOR flash minimal I/O size must be equal to the
> maximal size of the write buffer used by embedded flash
> programming algorithm. In case of NAND flash mtd->writebufsize
> should be equivalent to mtd->writesize.
>
> The subsequent patches will add mtd->writebufsize initialization
> where needed.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
I've tweaked your commentary a bit and pushed to l2-mtd-2.6.git, please,
check.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2010-12-19 17:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <292342500.2538.65.camel@localhost>
2010-12-16 22:42 ` [PATCH v2 0/6] Fix UBIFS recovery issues observed on NOR flash Anatolij Gustschin
2010-12-16 22:42 ` [PATCH v2 1/6] mtd: add writebufsize field to mtd_info struct Anatolij Gustschin
2010-12-19 17:45 ` Artem Bityutskiy [this message]
2010-12-20 9:15 ` Anatolij Gustschin
2010-12-16 22:42 ` [PATCH v2 2/6] mtd: cfi: add writebufsize initialization Anatolij Gustschin
2010-12-19 17:45 ` Artem Bityutskiy
2010-12-20 16:36 ` Guillaume LECERF
2010-12-21 14:45 ` Artem Bityutskiy
2010-12-30 10:32 ` Guillaume LECERF
2010-12-30 11:49 ` Guillaume LECERF
2011-01-05 8:27 ` Artem Bityutskiy
2011-01-06 11:13 ` Anatolij Gustschin
2011-01-06 11:14 ` Artem Bityutskiy
2011-01-06 11:00 ` Anatolij Gustschin
2011-01-06 10:49 ` Anatolij Gustschin
2011-01-06 10:48 ` Anatolij Gustschin
2010-12-16 22:42 ` [PATCH v2 3/6] mtd: nand: add mtd->writebufsize initialization Anatolij Gustschin
2010-12-16 22:42 ` [PATCH v2 4/6] mtd: onenand: " Anatolij Gustschin
2010-12-16 22:42 ` [PATCH v2 5/6] mtd: initialize writebufsize in the MTD object of a partition Anatolij Gustschin
2010-12-16 22:42 ` [PATCH v2 6/6] UBI: use mtd->writebufsize to set minimal I/O unit size Anatolij Gustschin
2010-12-19 17:46 ` Artem Bityutskiy
2010-12-20 9:18 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292780731.13362.16.camel@koala \
--to=dedekind1@gmail.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=agust@denx.de \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox