Re: [PATCH v2 2/6] mtd: cfi: add writebufsize initialization

Artem Bityutskiy
2010-12-21T14:46:03Z

On Mon, 2010-12-20 at 17:36 +0100, ext Guillaume LECERF wrote:
> Hello.
>
> 2010/12/16 Anatolij Gustschin <agust@denx.de>:
> > Initialize mtd->writebufsize to the value obtained
> > by CFI query command at probe time.
> >
> > Signed-off-by: Anatolij Gustschin <agust@denx.de>
> > ---
> > --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> > @@ -428,6 +428,10 @@ struct mtd_info *cfi_cmdset_0002(struct map_info *map, int primary)
> > mtd->flags = MTD_CAP_NORFLASH;
> > mtd->name = map->name;
> > mtd->writesize = 1;
> > + mtd->writebufsize = 1 << cfi->cfiq->MaxBufWriteSize;
>
> What about wbufsize initialized in cfi_amdstd_write_buffers() to
> "cfi_interleave(cfi) << cfi->cfiq->MaxBufWriteSize" ?
> I don't know this piece of code, but I just wanted to point it to you.

Yes, fair question, Anatolij?

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)