From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-bw0-f43.google.com ([209.85.214.43]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PUNL1-00061H-Bl for linux-mtd@lists.infradead.org; Sun, 19 Dec 2010 17:46:27 +0000 Received: by mail-bw0-f43.google.com with SMTP id 14so2470097bwz.30 for ; Sun, 19 Dec 2010 09:46:27 -0800 (PST) Subject: Re: [PATCH v2 6/6] UBI: use mtd->writebufsize to set minimal I/O unit size From: Artem Bityutskiy To: Anatolij Gustschin In-Reply-To: <1292539339-25111-7-git-send-email-agust@denx.de> References: <292342500.2538.65.camel@localhost> <1292539339-25111-7-git-send-email-agust@denx.de> Content-Type: text/plain; charset="UTF-8" Date: Sun, 19 Dec 2010 19:46:19 +0200 Message-ID: <1292780779.13362.18.camel@koala> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Artem Bityutskiy , linux-mtd@lists.infradead.org, David Woodhouse Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2010-12-16 at 23:42 +0100, Anatolij Gustschin wrote: > Previously we used mtd->writesize field to set UBI's minimal > I/O unit size. This sometimes caused UBIFS recovery issues > when mounting an uncleanly unmounted UBIFS partition on NOR > flash since mtd->writesize is 1 byte for NOR flash. The > MTD CFI driver however often performs writing multiple > bytes in one programming operation using the chip's write > buffer. We have to use the size of this write buffer as > a minimal I/O unit size for UBI on NOR flash to fix the > observed UBIFS recovery issues. > > Signed-off-by: Anatolij Gustschin I've re-wrote the commentary and pushed, please, check. -- Best Regards, Artem Bityutskiy (Битюцкий Артём)